impr: Ignore console.logs in vertex shaders by aleksanderkatan · Pull Request #1985 · software-mansion/TypeGPU

aleksanderkatan · 2025-12-16T12:23:52Z

Before:

After:

Changes:

remove isEntry from all functions shells (it was unused),
add entryPoint to make entry functions differentiable,
add type guards for entry functions (now they are no longer used in this pr, but since the code is already here, let's keep them),
add an internal slot that holds the info about current stage,
based on the slot, warn and fallback to a comment when a console.log is used on vertex stage (an overload is created if the function is used on both stages).

github-actions · 2025-12-16T12:25:21Z

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@951df0c9dba5610733532360b194354dd9565097

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@951df0c9dba5610733532360b194354dd9565097

https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@951df0c9dba5610733532360b194354dd9565097

benchmark
view benchmark

commit
view commit

Copilot

Pull request overview

This PR improves error handling when console.log is used in vertex shaders by detecting the shader stage during resolution and throwing a clear error instead of allowing invalid code generation.

Key changes:

Replaces the isEntry boolean flag with an entryPoint string field to distinguish between shader stages ('vertex', 'fragment', 'compute')
Tracks the current shader stage during resolution and validates console.log usage
Removes the deprecated does method from entry point function shells

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/typegpu/src/types.ts	Adds `ShaderStage` type definition for tracking shader stages
packages/typegpu/src/resolutionCtx.ts	Implements stage tracking logic and validates console.log usage based on current stage
packages/typegpu/src/core/function/tgpuVertexFn.ts	Replaces `isEntry` with `entryPoint: 'vertex'` and adds type guard
packages/typegpu/src/core/function/tgpuFragmentFn.ts	Replaces `isEntry` with `entryPoint: 'fragment'` and adds type guard
packages/typegpu/src/core/function/tgpuFn.ts	Removes unused `isEntry: false` from regular functions
packages/typegpu/src/core/function/tgpuComputeFn.ts	Replaces `isEntry` with `entryPoint: 'compute'` and adds type guard
packages/typegpu/tests/tgsl/consoleLog.test.ts	Adds test coverage for vertex shader console.log error handling
apps/typegpu-docs/src/examples/rendering/3d-fish/render.ts	Demonstrates the error by adding a console.log in a vertex shader

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…-logging-from-vertex

cieplypolar

LGTM 👍

packages/typegpu/src/core/function/tgpuComputeFn.ts

packages/typegpu/src/resolutionCtx.ts

packages/typegpu/tests/tgsl/consoleLog.test.ts

…-logging-from-vertex

packages/typegpu/src/resolutionCtx.ts

…-logging-from-vertex

github-actions · 2026-01-15T11:04:04Z

📊 Bundle Size Comparison

🟢 Decreased	➖ Unchanged	🔴 Increased	❔ Unknown
1	322	9	3

👀 Notable results

Static test results:

No major changes.

Dynamic test results:

Test	tsdown
common from typegpu.ts	54.92 kB ($${\color{red}+0.7\%}$$)
isTgpuComputeFn from typegpu.ts	76 B
isTgpuFragmentFn from typegpu.ts	77 B
isTgpuVertexFn from typegpu.ts	75 B

📋 All results

Click to reveal the results table (334 entries).

Test	tsdown
dataImportEverything.ts	80.07 kB (➖)
dataImportOneDirect.ts	40.68 kB (➖)
dataImportOneStar.ts	40.68 kB (➖)
functionWithUseGpu.ts	268 B (➖)
functionWithoutUseGpu.ts	24 B (➖)
importEntireLibrary.ts	259.17 kB ($${\color{red}+0.1\%}$$)
stdImportEverything.ts	112.84 kB (➖)
stdImportOneDirect.ts	62.19 kB (➖)
stdImportOneStar.ts	62.19 kB (➖)
tgpuImportEverything.ts	239.74 kB ($${\color{red}+0.1\%}$$)
tgpuImportOne.ts	239.75 kB ($${\color{red}+0.1\%}$$)
MissingBindGroupsError from typegpu.ts	1.29 kB (➖)
MissingLinksError from typegpu.ts	208 B (➖)
MissingSlotValueError from typegpu.ts	153 B (➖)
MissingVertexBuffersError from typegpu.ts	1.29 kB (➖)
NotUniformError from typegpu.ts	1.25 kB (➖)
ResolutionError from typegpu.ts	1.48 kB (➖)
Void from typegpudata.ts	675 B (➖)
abs from typegpustd.ts	78.86 kB (➖)
acos from typegpustd.ts	78.86 kB (➖)
acosh from typegpustd.ts	78.86 kB (➖)
add from typegpustd.ts	62.19 kB (➖)
align from typegpudata.ts	42.36 kB (➖)
alignmentOf from typegpudata.ts	38.78 kB (➖)
allEq from typegpustd.ts	64.59 kB (➖)
all from typegpustd.ts	64.59 kB (➖)
and from typegpustd.ts	64.59 kB (➖)
any from typegpustd.ts	64.60 kB (➖)
arrayLength from typegpustd.ts	11.31 kB (➖)
arrayOf from typegpudata.ts	42.57 kB (➖)
asin from typegpustd.ts	78.86 kB (➖)
asinh from typegpustd.ts	78.86 kB (➖)
atan2 from typegpustd.ts	78.86 kB (➖)
atan from typegpustd.ts	78.86 kB (➖)
atanh from typegpustd.ts	78.86 kB (➖)
atomicAdd from typegpustd.ts	12.70 kB (➖)
atomicAnd from typegpustd.ts	12.70 kB (➖)
atomicLoad from typegpustd.ts	12.68 kB (➖)
atomicMax from typegpustd.ts	12.70 kB (➖)
atomicMin from typegpustd.ts	12.70 kB (➖)
atomicOr from typegpustd.ts	12.70 kB (➖)
atomicStore from typegpustd.ts	12.69 kB (➖)
atomicSub from typegpustd.ts	12.70 kB (➖)
atomicXor from typegpustd.ts	12.70 kB (➖)
atomic from typegpudata.ts	714 B (➖)
bitcastU32toF32 from typegpustd.ts	59.96 kB (➖)
bitcastU32toI32 from typegpustd.ts	59.96 kB (➖)
bool from typegpudata.ts	10.84 kB (➖)
builtin from typegpudata.ts	44.92 kB (➖)
ceil from typegpustd.ts	78.86 kB (➖)
clamp from typegpustd.ts	78.86 kB (➖)
common from typegpu.ts	54.92 kB ($${\color{red}+0.7\%}$$)
comparisonSampler from typegpudata.ts	694 B (➖)
cos from typegpustd.ts	78.86 kB (➖)
cosh from typegpustd.ts	78.86 kB (➖)
countLeadingZeros from typegpustd.ts	78.86 kB (➖)
countOneBits from typegpustd.ts	78.86 kB (➖)
countTrailingZeros from typegpustd.ts	78.86 kB (➖)
cross from typegpustd.ts	78.86 kB (➖)
d from typegpu.ts	80.08 kB (➖)
deepEqual from typegpudata.ts	2.71 kB (➖)
degrees from typegpustd.ts	78.86 kB (➖)
determinant from typegpustd.ts	78.86 kB (➖)
disarrayOf from typegpudata.ts	12.80 kB (➖)
discard from typegpustd.ts	9.43 kB (➖)
distance from typegpustd.ts	78.86 kB (➖)
div from typegpustd.ts	62.19 kB (➖)
dot4I8Packed from typegpustd.ts	78.86 kB (➖)
dot4U8Packed from typegpustd.ts	78.86 kB (➖)
dot from typegpustd.ts	78.86 kB (➖)
dpdxCoarse from typegpustd.ts	10.28 kB (➖)
dpdxFine from typegpustd.ts	10.28 kB (➖)
dpdx from typegpustd.ts	10.28 kB (➖)
dpdyCoarse from typegpustd.ts	10.28 kB (➖)
dpdyFine from typegpustd.ts	10.28 kB (➖)
dpdy from typegpustd.ts	10.28 kB (➖)
eq from typegpustd.ts	64.59 kB (➖)
exp2 from typegpustd.ts	78.86 kB (➖)
exp from typegpustd.ts	78.86 kB (➖)
extensionEnabled from typegpustd.ts	12.36 kB (➖)
extractBits from typegpustd.ts	78.86 kB (➖)
f16 from typegpudata.ts	10.84 kB (➖)
f32 from typegpudata.ts	10.84 kB (➖)
faceForward from typegpustd.ts	78.86 kB (➖)
firstLeadingBit from typegpustd.ts	78.86 kB (➖)
firstTrailingBit from typegpustd.ts	78.86 kB (➖)
float16 from typegpudata.ts	37.76 kB (➖)
float16x2 from typegpudata.ts	37.76 kB (➖)
float16x4 from typegpudata.ts	37.76 kB (➖)
float32 from typegpudata.ts	37.76 kB (➖)
float32x2 from typegpudata.ts	37.76 kB (➖)
float32x3 from typegpudata.ts	37.76 kB (➖)
float32x4 from typegpudata.ts	37.76 kB (➖)
floor from typegpustd.ts	78.86 kB (➖)
fma from typegpustd.ts	78.86 kB (➖)
formatToWGSLType from typegpudata.ts	37.76 kB (➖)
fract from typegpustd.ts	78.86 kB (➖)
frexp from typegpustd.ts	78.86 kB (➖)
fwidthCoarse from typegpustd.ts	10.28 kB (➖)
fwidthFine from typegpustd.ts	10.28 kB (➖)
fwidth from typegpustd.ts	10.28 kB (➖)
ge from typegpustd.ts	64.59 kB (➖)
gt from typegpustd.ts	64.60 kB (➖)
i32 from typegpudata.ts	10.84 kB (➖)
identity2 from typegpustd.ts	43.22 kB (➖)
identity3 from typegpustd.ts	43.22 kB (➖)
identity4 from typegpustd.ts	43.22 kB (➖)
insertBits from typegpustd.ts	78.86 kB (➖)
interpolate from typegpudata.ts	42.36 kB (➖)
invariant from typegpudata.ts	42.73 kB (➖)
inverseSqrt from typegpustd.ts	78.86 kB (➖)
isAccessor from typegpu.ts	72 B (➖)
isAlignAttrib from typegpudata.ts	696 B (➖)
isAtomic from typegpudata.ts	696 B (➖)
isBufferShorthand from typegpu.ts	1.61 kB (➖)
isBuffer from typegpu.ts	98.05 kB (➖)
isBuiltinAttrib from typegpudata.ts	698 B (➖)
isBuiltin from typegpudata.ts	40.77 kB (➖)
isCloseTo from typegpustd.ts	64.60 kB (➖)
isComparisonSampler from typegpu.ts	65.43 kB (➖)
isData from typegpudata.ts	2.32 kB (➖)
isDecorated from typegpudata.ts	699 B (➖)
isDisarray from typegpudata.ts	1.62 kB (➖)
isInterpolateAttrib from typegpudata.ts	702 B (➖)
isLazy from typegpu.ts	68 B (➖)
isLocationAttrib from typegpudata.ts	699 B (➖)
isLooseData from typegpudata.ts	1.67 kB (➖)
isLooseDecorated from typegpudata.ts	1.63 kB (➖)
isMutableAccessor from typegpu.ts	80 B (➖)
isPackedData from typegpudata.ts	37.83 kB (➖)
isPtr from typegpudata.ts	693 B (➖)
isSampler from typegpu.ts	65.42 kB (➖)
isSizeAttrib from typegpudata.ts	695 B (➖)
isSlot from typegpu.ts	68 B (➖)
isTexture from typegpu.ts	65.41 kB (➖)
isTgpuComputeFn from typegpu.ts	76 B
isTgpuFn from typegpu.ts	706 B (➖)
isTgpuFragmentFn from typegpu.ts	77 B
isTgpuVertexFn from typegpu.ts	75 B
isUnstruct from typegpudata.ts	1.62 kB (➖)
isUsableAsRender from typegpu.ts	62 B (➖)
isUsableAsSampled from typegpu.ts	63 B (➖)
isUsableAsStorage from typegpu.ts	63 B (➖)
isUsableAsUniform from typegpu.ts	65.40 kB (➖)
isUsableAsVertex from typegpu.ts	98.04 kB (➖)
isVariable from typegpu.ts	67.21 kB (➖)
isWgslArray from typegpudata.ts	695 B (➖)
isWgslData from typegpudata.ts	1.25 kB (➖)
isWgslStruct from typegpudata.ts	696 B (➖)
ldexp from typegpustd.ts	78.86 kB (➖)
le from typegpustd.ts	64.60 kB (➖)
length from typegpustd.ts	78.86 kB (➖)
location from typegpudata.ts	42.36 kB (➖)
log2 from typegpustd.ts	78.86 kB (➖)
log from typegpustd.ts	78.86 kB (➖)
lt from typegpustd.ts	64.59 kB (➖)
mat2x2f from typegpudata.ts	43.22 kB (➖)
mat3x3f from typegpudata.ts	43.22 kB (➖)
mat4x4f from typegpudata.ts	43.22 kB (➖)
matToArray from typegpudata.ts	43.35 kB (➖)
max from typegpustd.ts	78.86 kB (➖)
min from typegpustd.ts	78.86 kB (➖)
mix from typegpustd.ts	78.86 kB (➖)
mod from typegpustd.ts	62.19 kB (➖)
modf from typegpustd.ts	78.86 kB (➖)
mul from typegpustd.ts	62.19 kB (➖)
ne from typegpustd.ts	64.59 kB (➖)
neg from typegpustd.ts	62.19 kB (➖)
normalize from typegpustd.ts	78.86 kB (➖)
not from typegpustd.ts	64.59 kB (➖)
or from typegpustd.ts	64.59 kB (➖)
pack2x16float from typegpustd.ts	51.81 kB (➖)
pack4x8unorm from typegpustd.ts	51.81 kB (➖)
packedFormats from typegpudata.ts	37.78 kB (➖)
pow from typegpustd.ts	78.86 kB (➖)
ptrFn from typegpudata.ts	800 B (➖)
ptrHandle from typegpudata.ts	792 B (➖)
ptrPrivate from typegpudata.ts	799 B (➖)
ptrStorage from typegpudata.ts	797 B (➖)
ptrUniform from typegpudata.ts	793 B (➖)
ptrWorkgroup from typegpudata.ts	801 B (➖)
quantizeToF16 from typegpustd.ts	78.86 kB (➖)
radians from typegpustd.ts	78.86 kB (➖)
ref from typegpudata.ts	4.09 kB (➖)
reflect from typegpustd.ts	78.86 kB (➖)
refract from typegpustd.ts	78.86 kB (➖)
reverseBits from typegpustd.ts	78.86 kB (➖)
rotateX4 from typegpustd.ts	62.91 kB (➖)
rotateY4 from typegpustd.ts	62.91 kB (➖)
rotateZ4 from typegpustd.ts	62.91 kB (➖)
rotationX4 from typegpustd.ts	43.22 kB (➖)
rotationY4 from typegpustd.ts	43.22 kB (➖)
rotationZ4 from typegpustd.ts	43.22 kB (➖)
round from typegpustd.ts	78.86 kB (➖)
sampler from typegpudata.ts	683 B (➖)
saturate from typegpustd.ts	78.86 kB (➖)
scale4 from typegpustd.ts	62.91 kB (➖)
scaling4 from typegpustd.ts	43.22 kB (➖)
select from typegpustd.ts	64.60 kB (➖)
sign from typegpustd.ts	78.86 kB (➖)
sin from typegpustd.ts	78.86 kB (➖)
sinh from typegpustd.ts	78.86 kB (➖)
sint16 from typegpudata.ts	37.76 kB (➖)
sint16x2 from typegpudata.ts	37.76 kB (➖)
sint16x4 from typegpudata.ts	37.76 kB (➖)
sint32 from typegpudata.ts	37.76 kB (➖)
sint32x2 from typegpudata.ts	37.76 kB (➖)
sint32x3 from typegpudata.ts	37.76 kB (➖)
sint32x4 from typegpudata.ts	37.76 kB (➖)
sint8 from typegpudata.ts	37.76 kB (➖)
sint8x2 from typegpudata.ts	37.76 kB (➖)
sint8x4 from typegpudata.ts	37.76 kB (➖)
sizeOf from typegpudata.ts	40.69 kB (➖)
size from typegpudata.ts	42.36 kB (➖)
smoothstep from typegpustd.ts	78.86 kB (➖)
snorm16 from typegpudata.ts	37.76 kB (➖)
snorm16x2 from typegpudata.ts	37.76 kB (➖)
snorm16x4 from typegpudata.ts	37.76 kB (➖)
snorm8 from typegpudata.ts	37.76 kB (➖)
snorm8x2 from typegpudata.ts	37.76 kB (➖)
snorm8x4 from typegpudata.ts	37.76 kB (➖)
sqrt from typegpustd.ts	78.86 kB (➖)
std from typegpu.ts	112.84 kB (➖)
step from typegpustd.ts	78.86 kB (➖)
storageBarrier from typegpustd.ts	12.70 kB (➖)
struct from typegpudata.ts	3.31 kB (➖)
sub from typegpustd.ts	62.19 kB (➖)
subgroupAdd from typegpustd.ts	39.85 kB (➖)
subgroupAll from typegpustd.ts	39.86 kB (➖)
subgroupAnd from typegpustd.ts	39.86 kB (➖)
subgroupAny from typegpustd.ts	39.86 kB (➖)
subgroupBallot from typegpustd.ts	39.86 kB (➖)
subgroupBroadcastFirst from typegpustd.ts	39.86 kB (➖)
subgroupBroadcast from typegpustd.ts	39.86 kB (➖)
subgroupElect from typegpustd.ts	39.86 kB (➖)
subgroupExclusiveAdd from typegpustd.ts	39.86 kB (➖)
subgroupExclusiveMul from typegpustd.ts	39.86 kB (➖)
subgroupInclusiveAdd from typegpustd.ts	39.86 kB (➖)
subgroupInclusiveMul from typegpustd.ts	39.86 kB (➖)
subgroupMax from typegpustd.ts	39.86 kB (➖)
subgroupMin from typegpustd.ts	39.86 kB (➖)
subgroupMul from typegpustd.ts	39.86 kB (➖)
subgroupOr from typegpustd.ts	39.86 kB (➖)
subgroupShuffleDown from typegpustd.ts	39.86 kB (➖)
subgroupShuffleUp from typegpustd.ts	39.86 kB (➖)
subgroupShuffleXor from typegpustd.ts	39.86 kB (➖)
subgroupShuffle from typegpustd.ts	39.86 kB (➖)
subgroupXor from typegpustd.ts	39.86 kB (➖)
tan from typegpustd.ts	78.86 kB (➖)
tanh from typegpustd.ts	78.86 kB (➖)
texture1d from typegpudata.ts	11.30 kB (➖)
texture2dArray from typegpudata.ts	11.32 kB (➖)
texture2d from typegpudata.ts	11.30 kB (➖)
texture3d from typegpudata.ts	11.30 kB (➖)
textureBarrier from typegpustd.ts	12.69 kB (➖)
textureCubeArray from typegpudata.ts	11.32 kB (➖)
textureCube from typegpudata.ts	11.30 kB (➖)
textureDepth2dArray from typegpudata.ts	11.30 kB (➖)
textureDepth2d from typegpudata.ts	11.29 kB (➖)
textureDepthCubeArray from typegpudata.ts	11.31 kB (➖)
textureDepthCube from typegpudata.ts	11.29 kB (➖)
textureDepthMultisampled2d from typegpudata.ts	11.31 kB (➖)
textureDimensions from typegpustd.ts	40.67 kB (➖)
textureExternal from typegpudata.ts	814 B (➖)
textureLoad from typegpustd.ts	40.67 kB (➖)
textureMultisampled2d from typegpudata.ts	11.32 kB (➖)
textureSampleBaseClampToEdge from typegpustd.ts	40.67 kB (➖)
textureSampleBias from typegpustd.ts	40.67 kB (➖)
textureSampleCompareLevel from typegpustd.ts	40.67 kB (➖)
textureSampleCompare from typegpustd.ts	40.67 kB (➖)
textureSampleLevel from typegpustd.ts	40.67 kB (➖)
textureSample from typegpustd.ts	40.67 kB (➖)
textureStorage1d from typegpudata.ts	978 B (➖)
textureStorage2dArray from typegpudata.ts	996 B (➖)
textureStorage2d from typegpudata.ts	978 B (➖)
textureStorage3d from typegpudata.ts	978 B (➖)
textureStore from typegpustd.ts	40.67 kB (➖)
tgpu.bindGroupLayout from typegpu.ts	74.31 kB (➖)
tgpu.comptime from typegpu.ts	12.14 kB (➖)
tgpu.const from typegpu.ts	66.28 kB (➖)
tgpu.fn from typegpu.ts	50.88 kB ($${\color{green}-0.0\%}$$)
tgpu.initFromDevice from typegpu.ts	231.24 kB ($${\color{red}+0.1\%}$$)
tgpu.init from typegpu.ts	231.75 kB ($${\color{red}+0.1\%}$$)
tgpu.lazy from typegpu.ts	1.15 kB (➖)
tgpu.privateVar from typegpu.ts	67.21 kB (➖)
tgpu.resolveWithContext from typegpu.ts	179.11 kB ($${\color{red}+0.0\%}$$)
tgpu.resolve from typegpu.ts	179.18 kB ($${\color{red}+0.0\%}$$)
tgpu.slot from typegpu.ts	1.58 kB (➖)
tgpu.vertexLayout from typegpu.ts	42.69 kB (➖)
tgpu.workgroupVar from typegpu.ts	67.21 kB (➖)
tgpu from typegpu.ts	239.75 kB ($${\color{red}+0.1\%}$$)
translate4 from typegpustd.ts	62.91 kB (➖)
translation4 from typegpustd.ts	43.22 kB (➖)
transpose from typegpustd.ts	78.86 kB (➖)
trunc from typegpustd.ts	78.86 kB (➖)
u16 from typegpudata.ts	10.87 kB (➖)
u32 from typegpudata.ts	10.84 kB (➖)
uint16 from typegpudata.ts	37.76 kB (➖)
uint16x2 from typegpudata.ts	37.76 kB (➖)
uint16x4 from typegpudata.ts	37.76 kB (➖)
uint32 from typegpudata.ts	37.76 kB (➖)
uint32x2 from typegpudata.ts	37.76 kB (➖)
uint32x3 from typegpudata.ts	37.76 kB (➖)
uint32x4 from typegpudata.ts	37.76 kB (➖)
uint8 from typegpudata.ts	37.76 kB (➖)
uint8x2 from typegpudata.ts	37.76 kB (➖)
uint8x4 from typegpudata.ts	37.76 kB (➖)
unorm10 10 10 2 from typegpudata.ts	37.76 kB (➖)
unorm16 from typegpudata.ts	37.76 kB (➖)
unorm16x2 from typegpudata.ts	37.76 kB (➖)
unorm16x4 from typegpudata.ts	37.76 kB (➖)
unorm8 from typegpudata.ts	37.76 kB (➖)
unorm8x2 from typegpudata.ts	37.76 kB (➖)
unorm8x4 bgra from typegpudata.ts	37.76 kB (➖)
unorm8x4 from typegpudata.ts	37.76 kB (➖)
unpack2x16float from typegpustd.ts	51.81 kB (➖)
unpack4x8unorm from typegpustd.ts	51.81 kB (➖)
unstruct from typegpudata.ts	1.58 kB (➖)
vec2b from typegpudata.ts	36.27 kB (➖)
vec2f from typegpudata.ts	36.27 kB (➖)
vec2h from typegpudata.ts	36.27 kB (➖)
vec2i from typegpudata.ts	36.27 kB (➖)
vec2u from typegpudata.ts	36.27 kB (➖)
vec3b from typegpudata.ts	36.27 kB (➖)
vec3f from typegpudata.ts	36.27 kB (➖)
vec3h from typegpudata.ts	36.27 kB (➖)
vec3i from typegpudata.ts	36.27 kB (➖)
vec3u from typegpudata.ts	36.27 kB (➖)
vec4b from typegpudata.ts	36.27 kB (➖)
vec4f from typegpudata.ts	36.27 kB (➖)
vec4h from typegpudata.ts	36.27 kB (➖)
vec4i from typegpudata.ts	36.27 kB (➖)
vec4u from typegpudata.ts	36.27 kB (➖)
workgroupBarrier from typegpustd.ts	12.69 kB (➖)

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

cieplypolar

LGTM! First internal slot 😊

apps/typegpu-docs/src/examples/tests/log-test/index.ts

Co-authored-by: Szymon Szulc <103948576+cieplypolar@users.noreply.github.com>

…-logging-from-vertex

lursz

LGTM 👍🏿

…-logging-from-vertex

Add an error

c82ea68

aleksanderkatan linked an issue Dec 16, 2025 that may be closed by this pull request

fix: Better error when console.logging from vertex shaders #1980

Closed

Aleksander Katan added 9 commits December 16, 2025 15:31

Refactor

77c5132

Remove public currentStage

8417be7

Keep entrypoint info on functions

84c0399

Remove remaining isEntry

9c108c0

Remove does from entrypoints

ed3d0ae

Remove resolveStage

10e27ab

Rename Stage to ShaderStage

675697a

Add more tests

e3e24a5

Fix circular dep

a1060a9

aleksanderkatan requested a review from Copilot December 16, 2025 16:05

Copilot AI reviewed Dec 16, 2025

View reviewed changes

Aleksander Katan added 2 commits December 16, 2025 17:08

smol

2f31c53

Merge remote-tracking branch 'origin/main' into fix/better-error-when…

45bf547

…-logging-from-vertex

aleksanderkatan requested review from cieplypolar, iwoplaza, lursz and reczkok December 16, 2025 16:24

aleksanderkatan marked this pull request as ready for review December 16, 2025 16:24

cieplypolar approved these changes Dec 17, 2025

View reviewed changes

Aleksander Katan and others added 5 commits December 18, 2025 13:48

Review fixes

3428f04

Merge remote-tracking branch 'origin/main' into fix/better-error-when…

14e6b7a

…-logging-from-vertex

Add a test

1310713

Merge branch 'main' into fix/better-error-when-logging-from-vertex

c820cd0

Merge branch 'main' into fix/better-error-when-logging-from-vertex

2ea9223

iwoplaza reviewed Dec 22, 2025

View reviewed changes

packages/typegpu/src/resolutionCtx.ts Outdated Show resolved Hide resolved

Aleksander Katan added 2 commits January 15, 2026 12:01

Merge remote-tracking branch 'origin/main' into fix/better-error-when…

e42761a

…-logging-from-vertex

Merge fixes

50c7f27

aleksanderkatan marked this pull request as draft January 15, 2026 11:03

Aleksander Katan added 4 commits January 15, 2026 13:50

Add shaderStageSlot

23083d3

Remove _currentStage

3054814

Update tests

fd0f6a9

Export type guards

f326bdf

aleksanderkatan changed the title ~~impr: Better error when logging from vertex shader~~ impr: Ignore console.logs in vertex shaders Jan 15, 2026

Update log test example

7dc5e64

aleksanderkatan requested a review from Copilot January 15, 2026 13:49

Copilot started reviewing on behalf of aleksanderkatan January 15, 2026 13:50 View session

This comment was marked as outdated.

Sign in to view

smol

c51df35

aleksanderkatan marked this pull request as ready for review January 15, 2026 13:55

aleksanderkatan requested review from cieplypolar and iwoplaza January 15, 2026 13:55

Update test

7579e3a

cieplypolar approved these changes Jan 15, 2026

View reviewed changes

apps/typegpu-docs/src/examples/tests/log-test/index.ts Outdated Show resolved Hide resolved

aleksanderkatan and others added 4 commits January 15, 2026 17:02

Update apps/typegpu-docs/src/examples/tests/log-test/index.ts

2e551d2

Co-authored-by: Szymon Szulc <103948576+cieplypolar@users.noreply.github.com>

Remove duplicated test

07c81be

Merge branch 'main' into fix/better-error-when-logging-from-vertex

e41cc9f

Merge remote-tracking branch 'origin/main' into fix/better-error-when…

7a17e0c

…-logging-from-vertex

lursz approved these changes Jan 29, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/better-error-when…

951df0c

…-logging-from-vertex

aleksanderkatan merged commit 06e58c1 into main Jan 29, 2026
4 checks passed

aleksanderkatan deleted the fix/better-error-when-logging-from-vertex branch February 9, 2026 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

impr: Ignore console.logs in vertex shaders#1985

impr: Ignore console.logs in vertex shaders#1985
aleksanderkatan merged 31 commits intomainfrom
fix/better-error-when-logging-from-vertex

aleksanderkatan commented Dec 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

cieplypolar left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

cieplypolar left a comment

Uh oh!

Uh oh!

lursz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aleksanderkatan commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cieplypolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle Size Comparison

👀 Notable results

Static test results:

Dynamic test results:

📋 All results

Uh oh!

This comment was marked as outdated.

Uh oh!

cieplypolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lursz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aleksanderkatan commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading